remove tildes from core/scss and icons/scss#1454
Open
shammy8 wants to merge 3 commits intomomentum-design:mainfrom
Open
remove tildes from core/scss and icons/scss#1454shammy8 wants to merge 3 commits intomomentum-design:mainfrom
shammy8 wants to merge 3 commits intomomentum-design:mainfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
- Coverage 94.00% 93.81% -0.20%
==========================================
Files 132 132
Lines 18320 18320
Branches 2814 2809 -5
==========================================
- Hits 17222 17186 -36
- Misses 1098 1134 +36 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sass-loader has deprecated the use of tilde for awhile now: https://github.com/webpack-contrib/sass-loader#resolving-import-at-rules
Angular 15 has totally stopped supporting tilde as well: angular/angular-cli#25266 (comment)
This PR removes the tilde from scss files in the core and icons packages.
I have left a couple of tildes in for example the ones in the core/app and core/templates folder as these one doesn't seem to affect us. I'm guessing since they get compiled to something else before being consumed by the end user.
(edit) looks like just removing the ~ doesn't work as it can't compile the app in core/app. I have changed it to use relative paths instead.
Related Issue
#1453
Motivation and Context
Allows the library to be used with Angular 15+ projects
How Has This Been Tested?
Types of changes
Checklist: